feat: state management for creators #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleortega
approved these changes
Jun 24, 2024
Comment on lines
+44
to
+47
| log::error!( | ||
| "error on checking if {address} is quest creator of {}", | ||
| instance.quest_id | ||
| ); |
There was a problem hiding this comment.
Should we log this error? seems a business validation and may can cause flood on logs in we get attacked
There was a problem hiding this comment.
Should we return Unauthorized on this case?
There was a problem hiding this comment.
Or maybe return HttpResponse::from_error(QuestError::NotQuestCreator)
There was a problem hiding this comment.
HttpResponse::from_error(QuestError::NotQuestCreator) is already considered in the first Ok() branch. The function returns an error when the DB fails, not when there is a mismatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: